search

mayokunadeniyi / Instant-Weather

An Android weather application implemented using the MVVM pattern, Retrofit2, Dagger Hilt, LiveData, ViewModel, Coroutines, Room, Navigation Components, Data Binding and some other libraries from the Android Jetpack.
MIT License
767 stars 165 forks source link

Replace showIf() fun by isVisible from androidx.core.view #30

Closed GeorgCantor closed 3 years ago

mayokunadeniyi commented 3 years ago

Hello @GeorgCantor, thank you for this suggestion, although I would argue that the showIf() function is much more readable than the isVisible and that's why I would love us to still make use of the showIf() extension function :) what do you think ?

GeorgCantor commented 3 years ago

I believe that using isVisible function allows you to reduce the amount of code. And in my opinion it is no less readable

GeorgCantor commented 3 years ago

And this function under the hood works just like the one you created

mayokunadeniyi commented 3 years ago

And this function under the hood works just like the one you created

Yes, these are very valid points! Thank you, I'll merge this right away!