search

mayope / keycloakmigration

Manage your Keycloak configuration with code.
https://mayope.net
MIT License
111 stars 23 forks source link

Fix Client model mapping in UpdateClient #32

Closed adetalhouet closed 3 years ago

adetalhouet commented 3 years ago

Hi,

Thanks for the project and the contribution, super stable and complete. I'm using this as part of my OCP GitOps installation; see here for reference.

The secret and rootUrl are in inversed order, as per as the model defined here, resulting in a wrongly configured client-secret down the road.

I haven't added any test, nor find that many tests in that area to validate model mapping, but as I faced this issue today, I figure I'll at least submit the PR to track it.

Let me know if you wish I add tests surrounding this.

Cheers

klg71 commented 3 years ago

Hey adetalhouet, thanks for finding and fixing it :+1: i don't see the necessity to test this separaretly. I'll merge it and release it as soon as possible. <3

klg71 commented 3 years ago

Released with https://github.com/mayope/keycloakmigration/releases/tag/0.2.22