search

mayope / keycloakmigration

Manage your Keycloak configuration with code.
https://mayope.net
MIT License
111 stars 23 forks source link

Add client scope config parameter and combability with Keycloak 20.0.3 #62

Closed haraldsegliens closed 1 year ago

haraldsegliens commented 1 year ago

Added following changes.

  1. Add client scope action now has a new parameter - config. It allows to control any generic parameter for client scope, for example, parameters for dynamic scopes.
  2. Realm by id function now also matches id with realm parameter. This was necessary because keycloak 20.0.3 initial generated master realm id is an uuid not "master".
  3. Correct hashes doesn't update hashes if no new changes are present. Fixed the hash replacement function because it was trying to find [oldhash] to replace with [newvalue], but [oldhash] doesn't exist in attributes, only this v2/0/[oldhash] exists. I still don't know how new hashes are placed only if new changes are present.
klg71 commented 1 year ago

Hey @haraldsegliens thanks as always for you thought-through contribution :) I'm glad to have you supporting this project 👍 There are some minor issues I would like to discuss about this request. I annotated them above :)

klg71 commented 1 year ago

There is only one small question left :)

klg71 commented 1 year ago

Alright I will release it as soon as possible :)

klg71 commented 1 year ago

Released with version 0.2.47, please check if it works @haraldsegliens :)

haraldsegliens commented 1 year ago

Finally got it through testing and to production. 0.2.47 works perfectly. thank you