mayoverse / kinship2

Pedigree creation, plotting, and analytics
GNU General Public License v2.0
13 stars 7 forks source link

Incorrect pedigree plot #13

Open magnusdv opened 1 year ago

magnusdv commented 1 year ago

Hi, I wonder if the latest CRAN version of kinship2 introduced a bug affecting alignment in some cases. Below is an example shown both versions.

Any idea what's going on? A fix would be much appreciated! Thanks for your good work. -M

Version 1.8.5 (correct)

library(kinship2, quietly = T)
packageVersion("kinship2")
#> [1] '1.8.5'

x = pedigree(id = 1:7, dad = c(0,0,0,1,3,0,3), mom = c(0,0,0,2,4,0,6), sex = c(1,2,1,2,1,2,1))
plot(x)

Version 1.9.6 (wrong)

library(kinship2, quietly = T)
packageVersion("kinship2")
#> [1] '1.9.6'

x = pedigree(id = 1:7, dad = c(0,0,0,1,3,0,3), mom = c(0,0,0,2,4,0,6), sex = c(1,2,1,2,1,2,1))
plot(x)

#> Did not plot the following people: 7

Created on 2022-12-29 with reprex v2.0.2

sinnweja commented 1 year ago

Thanks for letting me know. I'll look at it this weekend.

-Jason

From: Magnus Dehli Vigeland @.> Sent: Thursday, December 29, 2022 5:05 PM To: mayoverse/kinship2 @.> Cc: Subscribed @.***> Subject: [EXTERNAL] [mayoverse/kinship2] Incorrect pedigree plot (Issue #13)

Hi, I wonder if the latest CRAN version of kinship2 introduced a bug affecting alignment in some cases. Below is an example shown both versions.

Any idea what's going on? A fix would be much appreciated! Thanks for your good work. -M

Version 1.8.5 (correct)

library(kinship2, quietly = T)

packageVersion("kinship2")

> [1] '1.8.5'

x = pedigree(id = 1:7, dad = c(0,0,0,1,3,0,3), mom = c(0,0,0,2,4,0,6), sex = c(1,2,1,2,1,2,1))

plot(x)

[https://camo.githubusercontent.com/b2fedc6cabaa72939b95e9aa267402d7f9a465b3314efb926d0cd9da1a089fb5/68747470733a2f2f692e696d6775722e636f6d2f4466774b66776e2e706e67]https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcamo.githubusercontent.com%2Fb2fedc6cabaa72939b95e9aa267402d7f9a465b3314efb926d0cd9da1a089fb5%2F68747470733a2f2f692e696d6775722e636f6d2f4466774b66776e2e706e67&data=05%7C01%7CSinnwell.Jason%40mayo.edu%7Cba3be0515e9b4511de5908dae9f12450%7Ca25fff9c3f634fb29a8ad9bdd0321f9a%7C0%7C0%7C638079519153285111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dh47wlyzRg%2BmFeg8MX%2BbA2OLk0YvjkZxDB3AlBraja8%3D&reserved=0

Version 1.9.6 (wrong)

library(kinship2, quietly = T)

packageVersion("kinship2")

> [1] '1.9.6'

x = pedigree(id = 1:7, dad = c(0,0,0,1,3,0,3), mom = c(0,0,0,2,4,0,6), sex = c(1,2,1,2,1,2,1))

plot(x)

[https://camo.githubusercontent.com/2f9d843bc789e4857d383ce4253807d8d0529e775f7bee5b380954dce8007af8/68747470733a2f2f692e696d6775722e636f6d2f393374583453632e706e67]https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcamo.githubusercontent.com%2F2f9d843bc789e4857d383ce4253807d8d0529e775f7bee5b380954dce8007af8%2F68747470733a2f2f692e696d6775722e636f6d2f393374583453632e706e67&data=05%7C01%7CSinnwell.Jason%40mayo.edu%7Cba3be0515e9b4511de5908dae9f12450%7Ca25fff9c3f634fb29a8ad9bdd0321f9a%7C0%7C0%7C638079519153285111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w1fLIz%2FAjAwXqVak81eShVFwdruWFKI6SdUoB%2BbZHDw%3D&reserved=0

> Did not plot the following people: 7

Created on 2022-12-29 with reprex v2.0.2https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Freprex.tidyverse.org%2F&data=05%7C01%7CSinnwell.Jason%40mayo.edu%7Cba3be0515e9b4511de5908dae9f12450%7Ca25fff9c3f634fb29a8ad9bdd0321f9a%7C0%7C0%7C638079519153285111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rirIPXPYOcTtIX1MSafR6Yvau1OdRzPkocJid54sfNI%3D&reserved=0

- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmayoverse%2Fkinship2%2Fissues%2F13&data=05%7C01%7CSinnwell.Jason%40mayo.edu%7Cba3be0515e9b4511de5908dae9f12450%7Ca25fff9c3f634fb29a8ad9bdd0321f9a%7C0%7C0%7C638079519153285111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=B72Gc%2Be3WnIOV2qhua8dAIDqJuJfl9S%2FWNF9wdXLJyc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB574QG6W5Z35BOG7GYGZD3WPYKKDANCNFSM6AAAAAATMOODFA&data=05%7C01%7CSinnwell.Jason%40mayo.edu%7Cba3be0515e9b4511de5908dae9f12450%7Ca25fff9c3f634fb29a8ad9bdd0321f9a%7C0%7C0%7C638079519153285111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=T%2FoihKhgYIhKtBkJvc5YPB4mZIEupwKfgbp1SBGuuiI%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

alexkrohn commented 1 year ago

I too am having problems plotting a certain pedigree where one individual is plotted as floating without offspring even though the pedigree information says they have offspring. It doesn't seem to resolve itself by resorting back to an earlier version of kinship. Here's the input dataset.