mayoverse / kinship2

Pedigree creation, plotting, and analytics
GNU General Public License v2.0
15 stars 7 forks source link

Makekinship not a "bdsmatrix" #22

Closed LouisLeNezet closed 1 year ago

LouisLeNezet commented 1 year ago

Hi,

In the example of makekinship, the matrix is said to be a "bdsmatrix" but is in fact when the example is ran a "dscmatrix". Is it something wanted ?

data(minnbreast) 
table(minnbreast$sex)
length(unique(minnbreast$famid))

kin1 <- with(minnbreast,makekinship(famid, id, fatherid, motherid))
dim(kin1)

class(kin1)

# The next line shows that few of the elements of the full matrix are >0
length(kin1@blocks)/ prod(dim(kin1))

The consequence is that no parameter @blocks is available.

Louis

sinnweja commented 1 year ago

No, the bdsmatrix class was discontinued and we were encouraged to use dscmatrix classes. I do not see the kin1@blocks test anywhere now, and it is fine to remove that line.