search

mayppong / gyro

Elixir implementation of shawarmaspin
1 stars 0 forks source link

Mark spinner as inactive or offline #44

Open whiterook6 opened 8 years ago

whiterook6 commented 8 years ago

When sending spinner info to the client, mark with a boolean or something whether a spinner is actually spinning or not. This could allow the template to update with appropriate colors or shit.

mayppong commented 8 years ago

Currently, the only reference to an inactive spinner is in the legendary score board for both arena and the squad that spinner last belonged to. They are of course are marked with 0 spm by the scoreboard. You could currently use that to detect an inactive spinner.

The only concern I have for this method is that if in the future we allow spinners' spm to be interacted with directly, we could end up in a scenario where they are still online but the spm is 0. What I propose above should still be OK for now though until that point come. I could create a flag like inactive? or is_inactive or something later.