Some improvements...

[semoal]

Will fix:

89 Incompatible with React versions >16

40 is this hooks automatically disconnect channels?

43 Introduce to hoist channel connection

44 useChannel(false) to prevent eager channel connection

[semoal]

Just saw we don't even run tests in CI!

We'll do now, just pushed a github action that runs the test suite ;)

[semoal]

Let's see if we can get this merged/reviewed soon @mayteio don't want to introduce you hurry, we're using my fork meanwhile, but I'll prefer to use yours :)

[mayteio]

Thanks @semoal, sorry I'm not seeing the GitHub action in the checks?

[semoal]

Thanks @semoal, sorry I'm not seeing the GitHub action in the checks?

GitHub only runs actions that are on main/master branch. If you want cherry pick the action to main I can update the branch and the CI will run 👍

They made that cuz the crypto mining, if you haven’t any ci first has to be on main to run on branches, and then when on main if the pull request is open and first contributor, needs approval from you to run 🥵

[mayteio]

Nice, thanks @semoal! Approved and merged.

[antonykamp]

Hey guys 😇 Thanks, @semoal, for the fantastic improvements and @mayteio for merging. I would like to ask if you can publish the new version on npm, please 🙃 It would help us a lot! Thanks.

[fotoflo]

Hi im still seeing that it's incompatible with react 18... is that the case? or should i use --legacy-peer-deps (i don't like to do that...)

$ npm install @harelpls/use-pusher
npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: fastmonitor@0.1.0 npm ERR! Found: react@18.2.0 npm ERR! node_modules/react npm ERR! react@"18.2.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.9.0" from @harelpls/use-pusher@7.2.1

[JCMais]

@mayteio could you publish a new version with these fixes?