search

maythamfahmi / CryptoNet

CryptoNet is simple, fast and a lightweight asymmetric and symmetric encryption library.
https://github.com/maythamfahmi/CryptoNet
MIT License
99 stars 20 forks source link

[feature request]: Test coverage need to reach higher rate than today 70% #86

Open maythamfahmi opened 1 week ago

maythamfahmi commented 1 week ago

Contact Details

No response

Is your feature request related to a problem? Please describe.

not directly

Describe the solution you'd like

We want to imporve test coverage. Today it is aroud 70%, every thing 80% and up would be cool to reach.

Our ulitmate goal is to reach 100%.

Describe alternatives you've considered

No response

Additional context

No response

Priority Level

Low

Code of Conduct

maythamfahmi commented 1 week ago

with all new tests introduces we are already at above 80%, I think for this stage it is fine so far. I think few more test for extensions method and the todo mentioned in the code for RSA, I will look at it hopefully we can hit 90%

image

jwdonahue commented 1 week ago

I am generally not happy with anything less than 100%, except for the few occasional code paths that are more costly to cover, than expert review. Those are rare, and usually involve impossible corner-cases/code paths that are their purely to make the compiler happy (ie; default cases in switch statements, or exceptional paths that should never be hit). Simple libraries should approach 100% coverage, but not at the expense of alternate path permutations through the code. Complete coverage != thorough testing.

I am pleased to see the improvement in coverage though.

maythamfahmi commented 1 week ago

I agree with you if we can do 100% that would be awesome.