maze508 / pe

1 stars 0 forks source link

Schedule Does not handle Date Clashes #11

Open maze508 opened 4 months ago

maze508 commented 4 months ago

Details

Adding a schedule does not warn the user of date clashes at all. This means a user doesn't know when they are free and when they cannot schedule events. This is a feature flaw as it does not serve the purpose of appointment management when you can have multiple appointments at the same time

Steps to Reproduce

  1. schedule add h/Meeting with Client t/2/14/2024 0930 d/Discuss project details n/John Doe
  2. schedule add h/Meeting with Friend t/2/14/2024 0930 d/Discuss project details n/John Doe
  3. schedule add h/Breakfast t/2/14/2024 0930 d/Discuss project details n/John Doe
  4. schedule add h/Exercise t/2/14/2024 0930 d/Discuss project details n/John Doe
soc-pe-bot commented 4 months ago

Team's Response

It is possible that the social worker is meeting a group of people. For example, the social worker is meeting a group of elderly at a local Community Center event for a group therapy session (or any other reasons), in this scenario it is imperative that the social worker be able to meet with multiple clients at the same time.

This is a feature that can be added in future iterations of the applications (thus, we have changed to NotInScope).

Moreover, it is unlikely that users will be making mistakes by scheduling appointments on the same time, hence, we suggest reducing the severity to low.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Should not allow to schedule two event with the same client at the same time

When adding a scheduled appointment, it does not make sense to allow adding of a different appointment to the same person and the exact same date and time. This makes it hard to catch mistakes made when user accidentally enters wrong date/time resulting in overlapping appointments!

Steps to reproduce:

  1. Run command "schedule add h/Meeting with Client t/2/14/2024 0930 d/Discuss project details n/John Doe"
  2. Run command "schedule add h/Meeting with friend t/2/14/2024 0930 d/Discuss project details n/John Doe"

Expected output : "Error, appointment already exist with this person at this date and time"

Reason for severity : While this does not make the app unusable, it represents potential for huge issues when many appointments are stacked at the same time and date. It does not warn the user from adding mutliple appointments.

Actual output : A new appointment is added successfully. Screenshot 2024-04-19 at 4.54.11 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#2454] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is possible that the social worker is meeting a group of people. For example, the social worker is meeting a group of elderly at a local Community Center event for a group therapy session (or any other reasons), in this scenario it is imperative that the social worker be able to meet with multiple clients at the same time.

This is a feature that can be added in future iterations of the applications (thus, we have changed to NotInScope).

Moreover, it is unlikely that users will be making mistakes by scheduling appointments on the same time, hence, we suggest reducing the severity to low.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I respectfully disagree that my bug report is a duplicate of the other tester's issue. While both issues pertain to the scheduling functionality, the scope of our reports is fundamentally different. The original bug addresses the specific case of scheduling multiple appointments with the same client at the same time slot. In contrast, my report concerns the broader problem of the system's inability to warn of any clashes in the schedule, which can involve different clients and appointment types. This broader issue affects the OVERALL utility of the scheduling feature more significantly than the scenario outlined in the original bug.


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The application of the "NotInScope" label to my bug report is, in my view, incorrect. ConnectCare deals with 2 broad categories, Client Management AND Appointment Management. Additionally the User Guide's emphasis on appointment management indicates that the handling of appointments is a core function of the application. Not providing any form of conflict warnings for clashing appointments is a significant oversight that directly impacts this core functionality. Additionally, saying that "it is unlikely that users will be making mistakes by scheduling appointments on the same time" literally undermines the existence of scheduling apps, which I would have to respectfully disagree with. The argument that this could be a feature added in future iterations also does not diminish its relevance to the current version, it is a fundamental aspect of appointment management systems, and its absence is felt in the current iteration, especially given the target user base's needs. Additionally, your user stories **CLEARLY** states that a social worker should be able to schedule meetings to keep track of all appointments and **ensure there are no scheduling conflicts** which means this is a relevant issue.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I contest the severity downgrade of the issue from "Medium" to "Low." The ability to manage one's schedule efficiently and without conflict is a crucial component of the application, from your DG, a social worker should be able to schedule meetings to keep track of all appointments and **ensure there are no scheduling conflicts** which, respectfully, your app does not do. The likelihood of a user accidentally creating conflicting appointments increases with the volume of clients and appointments, and is a common scenario for the application's target users. The current lack of a conflict warning system places the onus on users to manually detect and resolve such conflicts, increasing the cognitive load and risk of error. Additionally, having conflicting schedule is disastrous for an app that literally promises no scheduling conflicts, imagine having to "Meet with Client" and "Lunch Break with CEO" and "Last Minute Debrief (with another client)" and "Fire Alarm Drill". Given the potential for this flaw to significantly impede the effectiveness of the appointment management side of ConnectCare, the severity should remain at "Medium." ![user_stories_connect_care.PNG](https://raw.githubusercontent.com/maze508/pe/main/files/ef8e05be-866d-453a-91f5-5b6bb2c0806c.PNG)