search

maze508 / pe

1 stars 0 forks source link

Restrictive Address Input Validation #8

Open maze508 opened 7 months ago

maze508 commented 7 months ago

Details

Address does not allow for repetitive [COMMAND]/ characters, like a/ or n/. This is restrictive as there may be addresses with these prefixes / suffixes which will not allow users to input them successfully

Steps to Reproduce

add n/Doe p/98765432 e/johnd@example.com a/311, Clementi a/b Ave 2, #02-25 k/Joe Doe d/Has a history of memory loss davi goliath t/mentalIllness t/owesMoney

nus-se-script commented 7 months ago

Team's Response

This issue does not make the product unusable, as the chance of the bug occurring is really low (not many addresses include the "/" character).

To fix this issue would be very difficult as other fields use other prefixes, which when parsing the command, might lead to the parser incorrectly parsing the contents of the address field as one of the other fields. We do also think that this feature should be left as NotInScope, as due to the difficulty, fixing it is less important than the work done in the current version of the product.

Moreover, an easy workaround is to change the "/" character to another special character like a space or "-", depending on the parameter. Therefore, we do not think that this would be a major inconvenience to the user.

The root cause of the issue is the same as issue #1060.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]