mazekkkk / openhab

Automatically exported from code.google.com/p/openhab
0 stars 0 forks source link

Migration issue from 1.1.0 to 1.2.0 for KNX configuration #245

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
I have following item in my items:
Switch Heating_GF_Living "Heating" <heating>    (gGF, Heating) { 
knx="<5/0/200+5/0/200" }   
It is perfectly working on 1.1.0, but once I migrated to the 1.2.0 it gives a 
problem.
There is an exception thrown and my items are not loaded due to that.
16:11:37.236 ERROR o.o.m.c.i.f.FolderObserver[:125]- An unexpected exception 
has occured
tuwien.auto.calimero.exception.KNXIllegalArgumentException: duplicate datapoint 
5/0/200
    at tuwien.auto.calimero.datapoint.DatapointMap.add(DatapointMap.java:106)
    at org.openhab.binding.knx.internal.config.KNXGenericBindingProvider.parseBindingConfigString(KNXGenericBindingProvider.java:371)
    at org.openhab.binding.knx.internal.config.KNXGenericBindingProvider.processBindingConfiguration(KNXGenericBindingProvider.java:126)
    at org.openhab.model.item.internal.GenericItemProvider.dispatchBindings(GenericItemProvider.java:224)
    at org.openhab.model.item.internal.GenericItemProvider.getItems(GenericItemProvider.java:137)
    at org.openhab.core.internal.items.ItemRegistryImpl.allItemsChanged(ItemRegistryImpl.java:226)

Original issue reported on code.google.com by ramazany...@gmail.com on 20 Apr 2013 at 2:24

GoogleCodeExporter commented 9 years ago
If I comment that line out issue is gone, but I need that item in my config. 
And it is perfectly working in 1.1.0.

Original comment by ramazany...@gmail.com on 20 Apr 2013 at 2:25

GoogleCodeExporter commented 9 years ago
simple check 
                    if(!configItem.allDataPoints.contains(dp)){
                        configItem.allDataPoints.add(dp);
                    }

solves a problem.
Could you adjust it in source ?

Original comment by ramazany...@gmail.com on 20 Apr 2013 at 3:21

GoogleCodeExporter commented 9 years ago
hmmm ... the Exception seems to report the problem correctly! You are going to 
add the same GA twice. Why do you add the same GA a second time as listening GA?

Original comment by teichsta on 20 Apr 2013 at 9:07

GoogleCodeExporter commented 9 years ago
because listening GA is the sam ein my case (keep in mind it is working 
configuration for 1.1.0)

Original comment by ramazany...@gmail.com on 21 Apr 2013 at 11:00

GoogleCodeExporter commented 9 years ago
It should be sufficient to configure the GA once. Having different GAs for 
Command and State is just a special case ...

Original comment by teichsta on 21 Apr 2013 at 12:01

GoogleCodeExporter commented 9 years ago
then please make a remark in wiki about upgrade. Currently it says that you 
just need to copy configurations from 1.1.0, which is not correct in my case.

Original comment by ramazany...@gmail.com on 21 Apr 2013 at 2:03

GoogleCodeExporter commented 9 years ago
ok, than let's say it the other way around: from my point of view it was more a 
bug than a feature that this configuration works with 1.1 ;-)

Original comment by teichsta on 21 Apr 2013 at 2:05

GoogleCodeExporter commented 9 years ago
ok, problem is clarified, so I'll reject this issue.

Original comment by kai.openhab on 22 May 2013 at 8:18