search

maziac / DeZog

Visual Studio Code Debugger for Z80/ZX Spectrum.
MIT License
212 stars 35 forks source link

Clear code coverage decoration does not clear history spot #10

Closed kborowinski closed 4 years ago

kborowinski commented 4 years ago

Describe the bug

Clear code coverage decoration does not clear history spot.

To Reproduce

dezog_decoration

Version etc. (please complete the following information):

maziac commented 4 years ago

Yes, "dezog: Clear current code coverage decoration" does clear only the code coverage.

The history spot uses the instruction history and not the code coverage. These are independent implementations.

Is this maybe documented wrongly? If so, please point me to the docs.

(at the moment) you cannot clear the instruction history. You can only disable it in the launch.json before you start a debug session.

Do you feel the need for such a command to clear the instruction history?

kborowinski commented 4 years ago

It would be useful to have command that clears decoration and history in one go so you don't have to issue two commands from the menu or if you are not willing to do that, then just add another command to clear history please.

BTW How to configure DeZog 0.12.0 (alpha) to work with ZEsarUX remote protocl. Could you have quick look at the #9

maziac commented 4 years ago

Would you like a command for enabling/disabling all the decorations or would you like a command to clear the instruction history (as with clearing the coverage). This is a little bit different. What is your intention here/for what purpose do you need the command?

"BTW How to configure DeZog 0.12.0 (alpha) to work with ZEsarUX remote protocl. Could you have quick look at the #9" Actually there is nothing special about 0.12.0. I use it with no problems on macOS and I also verified that it is working on Windows. Maybe something has gone wrong with the vsix files. I will issue an update soon, maybe you could try that once again.

kborowinski commented 4 years ago

I would like both:

  1. Option for enabling/disabling all the decorations, like you can do with history spot, ie: 
    "history": {
"spotCount": 0
}
  2. Command to clear instruction history. After debugging session I don't want the instructions history to be shown in the source. Right now I am reloading window (i.e. Developer: Reload Window) to clear the instructions history

Ps. OK, I'll try again after you update the vsix.

BTW Thanks for that amazing plugin, I use it on daily basis and love it!

maziac commented 4 years ago

I currently think of the following:

Could you please check if this would be OK for you.

kborowinski commented 4 years ago

That seems reasonable.

maziac commented 4 years ago

Here is the new release with the changes: https://github.com/maziac/DeZog/releases/tag/v0.13.0

kborowinski commented 4 years ago

I just did quick test with DeZog 0.13.0 and it looks like there is no decorations at all during debug session:

dezog_no_decorations

maziac commented 4 years ago

Please try with zesarux. The internal simulator has no coverage yet. Please wait for the next release :-)

kborowinski commented 4 years ago

I would love to test it with zesarux but zesaurx is giving me panic every single time I try to debug:

dezog_panic

maziac commented 4 years ago

I see :-(

I pinged Cesar once again about this. Let's see.

Meanwhile here is the 0.13.1 with coverage available for the internal simulator. https://github.com/maziac/DeZog/releases/tag/v0.13.1

(Only coverage, no history yet)

kborowinski commented 4 years ago

Thanks for pinging Cesar, it gets really frustrating to debug with Zesarux on Windows lately. And code coverage works great on 0.13.2 (I work on daily builds of DeZog ;)

maziac commented 4 years ago

I close this one. There is another 'issue' for the zesarux crash problem.