maziac / DeZog

Visual Studio Code Debugger for Z80/ZX Spectrum.
MIT License
210 stars 34 forks source link

Improvements for editing the memory contents in Memory View #111

Closed vampirehunt2 closed 1 week ago

vampirehunt2 commented 1 year ago

I would like to:

I could potentially contribute these changes.

maziac commented 1 year ago

If you want you can create a PR for this. But I could imagine it gets rather complicated.

If that would help, I could also extend the "-msetb" command to support a string and e.g. a series of bytes.

For the hex input (wo 'h') I'm not so sure: currently you have to use the extension everywhere else as well. Would be inconsistent here to have a hex input. And how should the decimal input work?

vampirehunt2 commented 1 year ago

how should the decimal input work? I would say if no base is specified AND hex digits are entered, default to hex. That would be my preferred method, however, since other people's requirements may vary, I was actually thinking of a user preference where you could set your default base for the Memory View.

maziac commented 1 year ago

So one would have to enter "10" for 10 or 0xA but if someone enters "F0" it would be 240 or 0xF0? Seems inconsistent to me.

vampirehunt2 commented 1 year ago

Basically, with the preference set to hex:

Similarly, with the preference set to dec:

maziac commented 1 week ago

Decided not to implement.