maziac / DeZog

Visual Studio Code Debugger for Z80/ZX Spectrum.
MIT License
212 stars 35 forks source link

Can't see values of memory view in light theme #41

Closed remy closed 3 years ago

remy commented 3 years ago

Describe the bug

Can't see values of memory view in light theme. Specifically the values are made bold and white - see screenshot (further in the issue).

To Reproduce

Steps to reproduce the behavior:

  1. Select a "light" theme i.e. "Light+ (default light)"
  2. Memory view from the console: -mv $c000 100
  3. The 100 highlighted bytes are white on a light background.

Expected behavior

Bold on the default font colour is used rather than white (or white hard coded).

Screenshots

Screenshot 2021-01-04 at 18 00 19

Version etc. (please complete the following information):

maziac commented 3 years ago

Thanks. Will correct that in the next release.

maziac commented 3 years ago

You can test if it works in the latest pre-release: https://github.com/maziac/DeZog/releases/tag/v2.1.0 (Don't forget to update the CSpect DeZog plugin as well).

remy commented 3 years ago
Screenshot 2021-01-05 at 17 07 23

Perfect - thank you 👍

I've spotted a regression in another point - do you want me raise it separately or on the back of this? (it's that -mv $c100 $ff doesn't work now, I have to type -mv 0xc100 0xff instead)…

remy commented 3 years ago

Ah, that regression seems to apply more broadly too - the conditional breakpoints don't support $ff syntax either:

Screenshot 2021-01-05 at 17 08 44
maziac commented 3 years ago

Yes, please enter another error. Did this work in the past ? I really can't remember?

remy commented 3 years ago

It did - and no problem, filing new issue 👍

maziac commented 3 years ago

Fixed in 2.1.0.