search

mazipan / tanyaaja.in

❓Kumpulkan pertanyaan secara anonim dari siapa saja dengan mudah
https://tanyaaja.in
MIT License
138 stars 38 forks source link

FEAT: add twitter handle #50

Closed theodorusclarence closed 1 year ago

theodorusclarence commented 1 year ago

Description

since you're still using twitter logo on the intent button, so I followed them.

image

CleanShot 2023-10-12 at 21 12 59@2x

Pre-requisites before merging

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.

@mazipan first needs to authorize it.

mazipan commented 1 year ago

Btw it is okay to just use a normal push instead of force push. I almost always using squash when merging the PR.

theodorusclarence commented 1 year ago

Btw it is okay to just use a normal push instead of force push. I almost always using squash when merging the PR.

Oh, just a force of habit 😃, I usually always rebase.

Noted

mazipan commented 1 year ago

Ah yeah, rebase is good for syncing with the remote.

But when you adding new commit, it is hard for maintainer to see what you have done, since the history can not be tracked. I can not see what you already change from the previous commit, so I need to re-review again from the beginning.

It is easy for small PR, but it's getting harder when the LOC is bigger.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanyaaja ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 9:30pm