Closed Namchee closed 1 year ago
Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.
@mazipan first needs to authorize it.
Most visited page for a logged in user is /account, it is like a landing page for a logged in user.
/account/settings on the other hand, have a lower visit numbers.
By using this info, how about we prioritize to showing the reminder on the /account?
Also I am thinking about using https://ui.shadcn.com/docs/components/alert with a dismiss button, what do you think?
Good idea, I'll show the callout on /account
page then and utilize shadcn for that.
After tidying this up, I think using Toast
with infinite duration is better solution than using Alert
because:
Toast
is dismissable while Alert
is not, which is better suited for reminders like this. While you can 'dismiss' alert by adding buttons to it, it is still faster to set Toast
with infinite duration instead since it has built-in removal.Toast
. Alert
on the other hand is designed to be 'integrated' with the page flow.This implementation will change if we can integrate the alert somewhere in the content. Do you have a UI design I can follow for this?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
tanyaaja | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 13, 2023 6:42am |
Closes #22
Description
This pull request adds reminder for account visibility settings in account settings page. It will be shown weekly whenever account visibility is not public.
Current Tasks
AccountVisibilityReminder
componentpublic
value on the form