FEAT: Add Confirm Dialog Before Mark as Done

amarangganar commented 1 year ago

Closes #69

Description

Showing confirmation dialog before marking a question as done

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.

@mazipan first needs to authorize it.

mazipan commented 1 year ago

Can we integrate with #77 instead @amarangganar? It is a rework.

But we can do in the separate PR also if you don't mind.

Let me know your thought about this

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tanyaaja	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2023 0:39am

amarangganar commented 1 year ago

I've tried to integrate it with #77, but I found edge cases while implementing it:

Dialog is closing immediately when clicking the submit button. To my understanding, the way to execute markAsDone on submit is through the then method like this dialog({...props}).then(() => markAsDone()), and using this method closes the dialog first before executing the markAsDone. The workaround I could think of is to show loading toast to let the users know it's processing.
Related to the above case, we can neither keep the dialog opened (subsequently make sure it's not accidentally closed while submitting) nor showing loading spinner on the submit button

Let me know what you think @mazipan

mazipan commented 1 year ago

Got it, thanks for confirming.

Let's keep as it is for now. Let me think later to improve the function.