search

mazipan / vue-currency-filter

🍒 Lightweight vue currency filter based on accounting.js
https://mazipan.github.io/vue-currency-filter/
MIT License
246 stars 29 forks source link

Cannot set thousands separator to '' or ' ' (space) #7

Closed sedyshev closed 6 years ago

sedyshev commented 7 years ago

Hello! Can you explain me what this line of code is doing: if(!thousandsSeparator || !isNaN(thousandsSeparator)) thousandsSeparator = '.'

I want to set thousands separator to space (or empty string), but this condition does not allow to do this

mazipan commented 7 years ago

I won't user set thousandsSeparator with any number. If it's number it will set to default.

mazipan commented 7 years ago

I already checked in demo page https://mazipan.github.io/vue-currency-filter/ and work well

mazipan commented 7 years ago

Oh I see,

It is because this code !thousandsSeparator Maybe you can create pull request to delete this line

Scalpel78 commented 6 years ago

We have the same problem, we also want to set thousandSeparator to ' '.