search

mazipan / vue-google-adsense

💰 Vue.js Google Adsense Component with InFeed and InArticle Ads support
https://mazipan.github.io/vue-google-adsense/
MIT License
257 stars 42 forks source link

data-ad-format option #14

Closed airnichols13 closed 5 years ago

airnichols13 commented 5 years ago

Hi again,

I noticed one more thing that may be useful to add (if I think what is happening is actually happening):

The responsive CSS I'm putting on the classes that go on the <ins> element are getting overridden, I believe by the presence of data-ad-format="auto". Looking at the adsense code I'm using on my current site vs the code your package creates, that seems to be the most meaningful difference.

Do you think that could be what's overriding my styles? If so, could data-ad-format become an option like the other data-ad-xxx options (with the option to turn it off with null)?

Thanks again for all your help!

mazipan commented 5 years ago

Sure, but today is public holiday in Jakarta. So maybe tommorow I will work on this

airnichols13 commented 5 years ago

Hi - any luck with this?

mazipan commented 5 years ago

Sorry, I have sick from Saturday (Jakarta Time). Today I hope I can work for this feature. Will update in this issue if any progress.

mazipan commented 5 years ago

Released on v1.5.0 ya @airnichols13

airnichols13 commented 5 years ago

Look like what you did is working, but IE11 is broken again:

Object doesn't support property or method 'assign'

I'm guessing it's a transpiling thing again?

mazipan commented 5 years ago

Fix in https://github.com/mazipan/vue-google-adsense/commit/7bdf5032c5dd71e5baaa506f17c373077f8ab545

airnichols13 commented 5 years ago

That worked - thanks again!