mazipan / vue-google-adsense

💰 Vue.js Google Adsense Component with InFeed and InArticle Ads support
https://mazipan.github.io/vue-google-adsense/
MIT License
257 stars 42 forks source link

🚀 New Feature - Vue 3 support #158

Open MDolega20 opened 3 years ago

MDolega20 commented 3 years ago

obraz

iann838 commented 3 years ago

Any news on Vue 3 Support ? I'm migrating some of the live apps from Vue 2 to Vue 3

mazipan commented 3 years ago

I have no bandwidth to do the migration. It also quite hard since the vue-script2 also not planning to support Vue 3 in the near time

iann838 commented 3 years ago

@mazipan I've made an alternative package of vue-script2 with Vue 3 and Typescript support called vue-scriptx

Npm: https://www.npmjs.com/package/vue-scriptx Repo: https://github.com/paaksing/vue-scriptx

It is still not production tested, would need some help on that.

mazipan commented 3 years ago

I may prefer to create seperate repo to support Vue 3, since it's hard for me to maintain 2 different version of code.

I will check when I have time @paaksing, thank you

beeequeue commented 3 years ago

Not much point in supporting two versions is there? Just drop Vue 2 in a breaking version update, and let people who still use Vue 2 use the old versions.

danividanivi commented 3 years ago

I may prefer to create seperate repo to support Vue 3, since it's hard for me to maintain 2 different version of code.

I will check when I have time @paaksing, thank you

Hi, did you have time to work on the Vue 3 repo?

iann838 commented 3 years ago

I may prefer to create seperate repo to support Vue 3, since it's hard for me to maintain 2 different version of code.

I will check when I have time @paaksing, thank you

Hi, did you have time to work on the Vue 3 repo?

If you meant the vue adsense repo, I'm not a dev of it, if you meant the vue script 2 repo, it's already on npm as vue-scriptx

euberdeveloper commented 2 years ago

Anzi news?

mazipan commented 2 years ago

Release under next tag https://github.com/mazipan/vue-google-adsense/releases/tag/2.0.0 It's nice if I can have you to test the release

the code itself still behind the branch: https://github.com/mazipan/vue-google-adsense/tree/next-vue3