mazx4960 / pe

0 stars 0 forks source link

Unexpected error message when a large index is supplied for `edit` #3

Open mazx4960 opened 2 years ago

mazx4960 commented 2 years ago

Problem

When a large index is supplied, the error message shown is invalid command even though it follows the command format

Steps to reproduce

edit 1000000000000000000000000 n/Bob

Expected

image.png

Actual behaviour

image.png

nus-se-script commented 2 years ago

Team's Response

Both have to do with the error message shown when large index is provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unexpected error message when large index is supplied for delete

Problem

When a large index is supplied, the error message shown is invalid command even though it follows the command format

Steps to reproduce

delete 1000000000000000000000000

Expected

image.png

Actual behaviour

image.png


[original: nus-cs2103-AY2122S2/pe-interim#1751] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the issue! This is caused by integer overflow and should have been handled in a better way.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]