search

mb-soft / BrewClub

Homebrew club software
1 stars 0 forks source link

Main entity creation #33

Closed mdryden closed 9 years ago

mdryden commented 9 years ago

Some comments for the review

ICollection properties on models are virtual to utilize lazy-loading (see: http://www.entityframeworktutorial.net/EntityFramework4.3/lazy-loading-with-dbcontext.aspx)

BrewClubContext overrides OnModelCreating method in order to have inherited objects use the "Table Per Type" strategy. (see: http://weblogs.asp.net/manavi/inheritance-mapping-strategies-with-entity-framework-code-first-ctp5-part-2-table-per-type-tpt)

mdryden commented 9 years ago

Assigned back to @bradpowell for followup review.

bradpowell commented 9 years ago

Assigned back to @pudds with new comments.

mdryden commented 9 years ago

Assigned back to @bradpowell.

I've added IDs to all EF models which don't inherit from PostedItem base class.

I think we should be ready to merge this one now.

bradpowell commented 9 years ago

Merge it baby. I imagine we probably want to delete the branch but we've never talked about it yet so I'll leave it.