QuickTools config confusing or bug?

mb1986 / rm-hacks

Small improvements and tweaks for rM devices, covering both rM1 and rM2.

Other

509 stars 11 forks source link

QuickTools config confusing or bug? #227

Closed RedTartan04 closed 7 months ago

RedTartan04 commented 7 months ago

Just tried out 0.0.9 - ace! I'm a little confused by the various QuickTools settings - maybe it's just the wording. I tried to get the QuickTools inside the toolbar above the other tools like in this screenshot but it'll always be next to the toolbar https://github.com/mb1986/rm-hacks/wiki/QuickTools#quicktools-hides-behind-the-toolbar-when-quicktools-is-vertical I only have enabled "QuickTools bar" and the two "details" switches. Changing "hides behind" seems to have no effect.

knox-dawson commented 7 months ago

[Edit: Okay, I'm dumb. I see what you mean now. I'm thinking that change was intentional (side by side instead of inline). I'll change the docs.]

I'm guessing a bit here. Hides behind: selected.

First,

When the toolbar is open, swiping up will open and close the quicktools next to the toolbar.
When the toolbar is closed, swiping up will open and close the quicktools in the toolbar location.

Second,

When both the toolbar and quicktools show side by side, closing the toolbar will move quicktools to the toolbar location
Then opening the toolbar should place the toolbar OVER the quicktools, and
Then closing the toolbar should uncover and display quicktools again.

Does that not happen for you?

knox-dawson commented 7 months ago

This page has changed https://github.com/mb1986/rm-hacks/wiki/QuickTools#quicktools-hides-behind-the-toolbar-when-quicktools-is-vertical.

Whether or not it is more clear, it is at least more accurate.

RedTartan04 commented 7 months ago

Thanks! It's sad the change was intentional :/ There's so much empty space in my toolbar.

The doc and the settings still say "If true, QuickTools is horizontal on top, otherwise it will be vertical below or next to the toolbar." - it's always next to it, that's what you mean has changed, right? and you/they missed to update this sentence? 🤪

knox-dawson commented 7 months ago

Thanks! It's sad the change was intentional :/ There's so much empty space in my toolbar.

I think the change was intentional, but I could be wrong. I've run out of space in my toolbar in landscape mode. (Of course, what I'm showing is the full-size toolbar. When I decrease the width, it also decreases the height -- a big "Yay!" for that. But some folks may not want to do that.)

The doc and the settings still say "If true, QuickTools is horizontal on top, otherwise it will be vertical below or next to the toolbar." - it's always next to it, that's what you mean has changed, right? and you/they missed to update this sentence? 🤪

Hmm, I can change the docs. I think I'll compile a list of menu wording that might need changes and I'll include that.

[Edit: docs changed]

RedTartan04 commented 7 months ago

Ah, saw your wording collection. In my understanding (not a native speaker) "below" means it's downwards, i.e. the quicktools would be further down the screen, while "under" means it's in this case behind the toolbar.

Here's what my toolbar looks like screenshot so I thought it would make sense to position the quicktools inside the toolbar strip. :)