mb1986 / rm-hacks

Small improvements and tweaks for rM devices, covering both rM1 and rM2.
Other
439 stars 9 forks source link

One finger swipe for scroll down broken in 0.0.10-alpha.5 #280

Open ingatellent opened 4 months ago

ingatellent commented 4 months ago

On my RM1 even with all gestures turned off one finger swipes for navigation/scrolling does not work in 0.0.10-alpha5.

This is a native scroll feature, and should probably not be removed unless the user explicitly wants to. Not the only way to scroll down, say in a portrait document shown in landscape mode is to use two fingers.

Scroll up works fine.

KnutSolvig commented 4 months ago

Both up and down scrolling works fine for me. I have disabled QuickTools show and hide and also Toolbar show and hide gestures.

ingatellent commented 4 months ago

Is this also on an RM1 on alpha.5 (3.9.5.2026)?

For me it has stopped working somewhere in the alphas for version 0.0.10 (and yes, I have disabled all custom gestures including QuickTools).

KnutSolvig commented 4 months ago

Oh sorry, I misread. rM2 here.

atngames commented 4 months ago

I can confirm it works on rm2

@mb1986 can you confirm it being broken on rm1?

ingatellent commented 3 months ago

I really miss being able to scroll down with one finger, so I tried downgrading to 0.0.9 (the released version), and I experience the same thing: Without hacks scroll down using one finger down swipe works fine. As soon as I install the hacks this gesture does not work any more.

I have tried enabling and disabling a lot of different features, but I have had no luck with pinpointing any settings for which the swipe work. I of course understand, that when quick tools is enabled then the One Finger Down gesture is used to toggle that (and this works!), but nothing happens when I use the gesture when quicktools is toggled off.

mb1986 commented 3 months ago

Having 0.0.9 you may disable "Gesture to toggle toolbar" and one-finger scroll should be back working.

On Tue, Mar 19, 2024, 12:11 ingatellent @.***> wrote:

I really miss being able to scroll down with one finger, so I tried downgrading to 0.0.9 (the released version), and I experience the same thing: Without hacks scroll down using one finger down swipe works fine. As soon as I install the hacks this gesture does not work any more.

I have tried enabling and disabling a lot of different features, but I have had no luck with pinpointing any settings for which the swipe work. I of course understand, that when quick tools is enabled then the One Finger Down gesture is used to toggle that (and this works!), but nothing happens when I use the gesture when quicktools is toggled off.

— Reply to this email directly, view it on GitHub https://github.com/mb1986/rm-hacks/issues/280#issuecomment-2006881772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKSTM2MUU5LCC6JKRWI6ULYZAMMNAVCNFSM6AAAAABEEWWFLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWHA4DCNZXGI . You are receiving this because you were mentioned.Message ID: @.***>

ingatellent commented 3 months ago

I am sorry, I miswrote (and in this browser GitHub does not allow editing of posts). It is the One Finger Up gesture, which I use to scroll down which isn't working.

Scrolling up (as mentioned above) works fine in any version I have tried.

mb1986 commented 3 months ago

https://github.com/mb1986/rm-hacks/assets/1386931/97ff189f-fb56-4bab-a2c8-e1c4c9d174da

ingatellent commented 3 months ago

Thank you, for taking your time to check this. Unfortunately, I cannot get this gesture working on my RM1.

I tried uninstalling the hacks, removing all traces of the hacks from xochitl.conf, reinstalling the hacks, and then turing off quicktools and gesture to hide/show toolbar. Still no luck: I can scroll down, but I cannot scroll up.

It works fine when the hacks are uninstalled, but not when they are installed.

I tried upgrading to 3.10 and installing 0.0.9-alpha.1, same behaviour, scrolling down does not work.

Is there anything except factory resetting, I could try, say some secret settings file or similar, which may be corrupted on my tablet?

ingatellent commented 3 months ago

A factory reset did not solve my problem. The One Finger Up gesture is still dead when rm-hacks are installed and quicktools disabled.

I wonder if this is related to me having installed the gestures-actions-mappings, but except for some wrongly registered aftion for One Finger Up-gesture, I have no idea why my tablet works differently than yours in the video.

When quicktools are enabled the One finger up gesture correctly toggles quicktools, hence the gesture is definitely caught and processed, correctly, it's just the scrolling action, which i missing.

Currently using 3.10 with 0.0.9-alpha.1 on my rm1.

atngames commented 3 months ago

Sorry if this is redundant but I just want to be sure: did you also disable the quick tools gesture in the gestures settings menu?

PepikVaio commented 3 months ago

Do you have the open and close gesture disabled?

ingatellent commented 3 months ago

Thank you so much @atngames – I feel rather stupid, but also extremely satisfied. Thanks for all your work on the hacks all of you. Here is a reproducible bug report, you can actually use to fix this issue:

Disabling quicktools removed the toggle for the quicktools gesture in Gestures settings, hence: If you disable quicktools with this gesture turned on in Gestures, there is no way of disabling this gesture, but it just does nothing.

Suggested fix: Disabling quicktools should turn the gesture off. Alternative fix: Disabling quicktools should not hide the toggle in Gestures. Manual fix: Turn off the gesture in Gestures before turning off quicktools.

The reason I never found this hidden preference on my own, was that the Gestures settings are placed below the Quicktools settings, hence I always enter Quicktools settings first, before going into Gestures.