search

mb1986 / rm-hacks

Small improvements and tweaks for rM devices, covering both rM1 and rM2.
Other
438 stars 9 forks source link

The Quick Tool does not replace the toggle bar button unless the quick tool is set to vertical mode. #351

Open Fvazimas opened 3 weeks ago

Fvazimas commented 3 weeks ago

I have remarkable 2 with version 3.11.2.5 and rM hacks v0.0.10. I have disabled the toolbar toggle button and enabled the quick toolbar option to act as the toggle button. But instead, i not only get the quick tool but also the toggle button for the toolbar but in the form of a quick tool option. WIN_20240605_17_08_30_Pro

knox-dawson commented 3 weeks ago

I have disabled the toolbar toggle button and enabled the quick toolbar option to act as the toggle button.

I may not be following. But there isn't an option to "enable the quick toolbar option to act as the toggle button." Again, I might not understand what you mean.

That's one thing. Then there's this

But instead, i not only get the quick tool but also the toggle button for the toolbar but in the form of a quick tool option.

That toggle button for the toolbar that you see is set in the Document Configuration as "Hide the toolbar button" and you appear to have it unselected. So there are (at least) two places that affect that upper left corner: "Hide the toolbar button" (Document Configuration) and "Hide toolbar header" (Toolbar Configuration).

Finally

The Quick Tool does not replace the toggle bar button unless the quick tool is set to vertical mode.

Maybe I'm missing something, but with the settings you seem to have, in vertical mode you should still see the toolbar toggle button (as a brush icon) with the quicktools below that.

I found it challenging (still do) to explain all the things that affect that upper left corner, what with the document settings, the toolbar settings, and the quicktools settings. And all this long-winded explanation may be beside the point if I'm not understanding your problem correctly.

Fvazimas commented 3 weeks ago

Hi, thanks for taking the time to try to explain my issue, and apologies if I did not explain it in a comprehensible way.

I may not be following. But there isn't an option to "enable the quick toolbar option to act as the toggle button." Again, I might not understand what you mean.

As I understand it there is an option to do that, in (Quick Tools Configuration) menu, it is called "Quick Tools as header" which says "Replace the toolbar toggle with the Quick Tools bar"------>(I have it enabled).

That toggle button for the toolbar that you see is set in the Document Configuration as "Hide the toolbar button" and you appear to have it unselected. So there are (at least) two places that affect that upper left corner: "Hide the toolbar button" (Document Configuration) and "Hide toolbar header" (Toolbar Configuration).

So yeah in fact you were partly right. I did not have the "Hide the toolbar button" enabled in the (Document Settings) menu, but after I did there was no change. As far as the (Toolbar settings) are concerned I already had enabled the "Hide toolbar leader", thus I do not believe my problem arises from these settings (necessarily).

Maybe I'm missing something, but with the settings you seem to have, in vertical mode you should still see the toolbar toggle button (as a brush icon) with the quicktools below that.

Well, that's what I thought too, but after I disabled the option "QuickTools is horizontal on top" the quick tools acted as the toggle button but only in the sense that now there are only 2 icons (those of only the toolbar) but unfortunately they did not work as a toggle button for the toolbar and I had(still do) to activate the toolbar using one of the gestures. WIN_20240606_09_46_01_Pro

Finally, it is my understanding that while the quick tools may replace the toggle button for the toolbar in vertical mode, it does not replace its functionality(meaning that if I press the "first" quick tool icon it will not open the toolbar) possibly because there is no code to do that. And for the horizontal mode, I believe that this is just a bug that can be fixed or a logical mistake in the code. Again thank you for your response.

knox-dawson commented 3 weeks ago

It sounds like you have a good understanding. I'm pretty sure there aren't any plans to have quicktools perform the toggle function. That is, if you hide the toggle, you'll have to use the gesture to open/close the toolbar, regardless of quicktools settings.

Fvazimas commented 3 weeks ago

Ok thanks again for answering me again . Should I close the issue and open another one as feature request or should I leave it as it is ?

knox-dawson commented 3 weeks ago

Ok thanks again for answering me again . Should I close the issue and open another one as feature request or should I leave it as it is ?

I guess it's up to you. But I'm not sure what your feature request would be. Are you saying that you want the icon in the corner to open and close the toolbar? If so, how would you select that tool?