search

mb1986 / rm-hacks

Small improvements and tweaks for rM devices, covering both rM1 and rM2.
Other
524 stars 10 forks source link

Feature request: Option for less obtrusive tool icon (50x50 area instead of 100x100) #88

Closed sztanj closed 8 months ago

sztanj commented 10 months ago

I got used to the ddvk hacks which packed the tool icon into roughly 50x50 pixels in the very corner of the screen. The rm-hacks claim the same icon area as the native firmware, which seems to be 100x100 pixels or four times larger than ddvk.

From ddvk I am used to using the top left corner of the page for dates, etc, and I don't like the obtrusive icon and its larger hitbox. Would it be possible to add an option for less obtrusive tool icon?

Below are screenshots from ddvk and from rm-hacks 0.0.7 along with a mockup that keeps the large color swatch, but packs it into a smaller 50x50 px area like ddvk.

Current rm-hacks marker icon 100x100: 231211_rm-hacks_tool-icon_100x100

Mockup of same marker icon packed into 50x50: 231211_rm-hacks_tool-icon_50x50_packed

ddvk screenshot with eraser icon: 231123_2 15ddvk_Toolbar closed

rm-hacks screenshot with eraser icon: 231211_3 8x_rm-hacks0 0 7_Toolbar closed_eraser

Please consider this. But regardless, thank you for all the work you have done!

PepikVaio commented 10 months ago

I, on the other hand, like that it's consistent and if you have a PDF that matches the rm panel interface, the 104x104px icon is better because it doesn't break the look.

If you prefer the icon on the left, move the panel to the left.

Tanishama commented 10 months ago

I think it is a great idea. Coming from Ddvk I appreciated the small size of that icon. It is ok the way it is now, but the more free space the better. Maybe it could be optional.

rudy0ne commented 10 months ago

I would not want that enhancement to come with a reduction of the gesture activation area.

Also, the circular color swatch is often useless on its own and would still benefit from an abbreviation (#71) of the color. But perhaps something like in this screenshot could work:

Screen Shot 2023-12-12 at 9 21 02 AM

Or:

11

martinhess-at commented 10 months ago

I got used to the ddvk hacks which packed the tool icon into roughly 50x50 pixels in the very corner of the screen. The rm-hacks claim the same icon area as the native firmware, which seems to be 100x100 pixels or four times larger than ddvk.

From ddvk I am used to using the top left corner of the page for dates, etc, and I don't like the obtrusive icon and its larger hitbox. Would it be possible to add an option for less obtrusive tool icon?

Below are screenshots from ddvk and from rm-hacks 0.0.7 along with a mockup that keeps the large color swatch, but packs it into a smaller 50x50 px area like ddvk.

Current rm-hacks marker icon 100x100: 231211_rm-hacks_tool-icon_100x100

Mockup of same marker icon packed into 50x50: 231211_rm-hacks_tool-icon_50x50_packed

ddvk screenshot with eraser icon: 231123_2 15ddvk_Toolbar closed

rm-hacks screenshot with eraser icon: 231211_3 8x_rm-hacks0 0 7_Toolbar closed_eraser

Please consider this. But regardless, thank you for all the work you have done!

hi there! i came the same way from 2.14. with ddvk and then was stuck with no hack at 3.8.3.1986. since 0.0.7. is now open for the version i'm astonished how different it is to ddvks now. and i'm missing some things. one of which is the small icon on the top of course. i think rudys and sztanjis proposals would be a big improvement.. have a nice day, thanks martin

sztanj commented 10 months ago

I agree with the suggestions to make this optional and to include indication of the tool color if possible.

I would not want that enhancement to come with a reduction of the gesture activation area.

I also agree with this comment from @rudy0ne. I like the fingertip swipe gestures in the upper left corner and find them easier to trigger in rm-hacks than they were in ddvk so I don't want to change their implementation.

In mentioning the icon area's "hitbox" in my original post, I more meant that I am unable to start a pen stroke within the 100x100 icon area, even though much of it is empty space. With ddvk I could start pen strokes in the opened-up parts of the icon area, and that gives more freedom to write in the upper left of the page.

PepikVaio commented 9 months ago

For me, if you're going to shrink it, shrink the whole panel. To make it user-friendly for the eyes.

Who has used DDVK?, did you find it strange when a large panel appeared and when closed the icon was small?

mb1986 commented 9 months ago

I am just messing with sizes of the toolbar itself. The original width of the toolbar is 104. I think reducing it to 75% which is 78 would be fine. Smaller value may be to small in my opinion.

On the other hand I'll try to reduce the brush icon to about 50.

I think I'll add two different configuration entries to enable/disable them separately.

What do you think?

PepikVaio commented 9 months ago

I think that would be about right. I don't know how wide the supernote is, but it's about 9 mm.

75% reMarkable would be about 8.25 mm. That makes sense to me.

PepikVaio commented 9 months ago

Send a test of the code and we'll try both 50px and 75px variants

mb1986 commented 9 months ago

It cannot be as small as 54... 😭

IMG20240109203837.jpg

PepikVaio commented 9 months ago

It is 54 px? And icon is to smaller too?

mb1986 commented 9 months ago

The icon is fine, but the pen size or color is not readable. I'll reduce it to 75% of the original size, and then you can test it.

PepikVaio commented 9 months ago

OK

mb1986 commented 9 months ago

This one is ready for testing:

sh -c "$(wget https://raw.githubusercontent.com/mb1986/rm-hacks/main/install.sh -O-)" _ patch 0.0.9-alpha.3
sztanj commented 9 months ago

I like it! Thank you very much! To me this satisfies my original request.

240111_rm-hacks_tool-icon_0 0 9 a_packed_hitboxes ↑ Old hitbox in red, new smaller hitboxes in green

PepikVaio commented 9 months ago

I'm at work - can't try it, gotta wait till tonight, damn it :)

dreadful-brain commented 9 months ago

I have just tested it and all I can say is: AWESOME. The menu looks so much better than before. You are amazing!

martinhess-at commented 9 months ago

Congrats! The new menu is supersweet ;)

mb1986 commented 9 months ago

I am happy you like it :)

PepikVaio commented 9 months ago

I mean, big change. What is the width in px please? Did you make a percentage change or did you set the size in px? I have a template linked to it and it matches my bar (not now), so I want to know how to adjust.

Appearance: It's different, at first I thought it was weird (unusual). Now it's a bit better :) And tomorrow it will be a blast and I won't be able to be without it :) And once I switch back, I'll be wondering what the heck???

It looks to me like an 11 x 11 mm square without the hack. And with the hack, it's 8mm wide and almost 9mm high.

Choosing a pen color - put a wider rectangle in there it's too narrow and looks weird.

Edit: As soon as I hide the sidebar, the ball slides up. I hated this with DDVK :( It's distracting because it makes a certain animation and ugly. Ideally, the ball should still be docked in the same place.

Workaround: Once the ball stays in place the pen icon (if enabled) will be lower (now travels up) and there will be no contact between the pen icon and the selected color. But I would also put some pixels there so they don't touch the edge of the screen. Like the clock (if it's displayed), it seems to me to have a few pixels there.

Solves the problem #71

The problem: it seems to me that I have less success opening or closing the panel. No hack 10 attempts and 10x success. With the hack 10 attempts and 5x success.

PepikVaio commented 9 months ago

One more problem: The information at the bottom is now wider than the panel itself and it doesn't fit the eye.

IMG_3251

mb1986 commented 9 months ago

What is the width in px please? Did you make a percentage change or did you set the size in px?

I've reduced 104 to 78 (75%).

PepikVaio commented 9 months ago

I've now realised that when the panel is closed, that's when the ball is in the right place. Equally aligned from the left (or right) and from the top.

I mean, can the panel move up when open? When the panel is open, the ball scrolls down.

Thank you

Kelvin88 commented 9 months ago

Slim toolbar and icon works. Like that a lot.

PepikVaio commented 9 months ago

Hi, please let me know if the moving icon when opening and closing the panel will be fixed? Or does it make any sense?

Thank you, I am sending a video of testing.

https://github.com/mb1986/rm-hacks/assets/36114753/f8eb5e02-b116-44bd-a908-b4ea99677f49

martinhess-at commented 9 months ago

Hi Josef, how do you manage to see the ball in a document, when the menu is hidden? Normally there is a tool visible, no? Its just when you make a new notebook? But i see it in the video testing. Me curious how many requests mb1986 will be wanting and able to solve. But anyway, very nice work for us! And for the use of the rM... ;) Thanks & Regards Martin

PepikVaio commented 9 months ago

You can choose to see the tool (hack) or turn it off and see the ball (original).

martinhess-at commented 9 months ago

Ahh, i see!

PepikVaio commented 9 months ago

Hi, please let me know if the moving icon when opening and closing the panel will be fixed? Or does it make any sense?

Thank you, I am sending a video of testing.

IMG_3268.mov

Now I know why the ball is moving. I figured it out when I took a moment to view the clock. When the panel closes, the sphere is placed where it's supposed to be. But when the panel is opened, it moves down like in the video because that's where the clock is kept. But I don't have the clock active, so I don't need the space.

I get it now, but can it be fixed? When the clock is not displayed, the panel will not travel down.

PepikVaio commented 9 months ago

One more problem: The information at the bottom is now wider than the panel itself and it doesn't fit the eye.

IMG_3251

Here I would also solve it so that the wifi information etc has a separate place on the panel, the tribute does not fit when shrinking as when the panel is the original wide.

knox-dawson commented 9 months ago

I wonder if this might be an answer (plug for my wish list issue): https://github.com/mb1986/rm-hacks/issues/109