mb21 / panwriter

Markdown editor with pandoc integration and paginated preview.
https://PanWriter.com
GNU General Public License v3.0
1.04k stars 49 forks source link

Error with AppImage distribution and 0.6.3 #15

Closed kiwnix closed 4 years ago

kiwnix commented 5 years ago

When running appimage distribution in debian buster, the following error is displayed:

[26367:0516/194739.179205:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_panwrip9eVNH/chrome-sandbox is owned by root and has mode 4755. zsh: trace trap ./panwriter-0.6.3-x86_64.AppImage

The 0.6.2 AppImage file works.

mb21 commented 5 years ago

Thanks for the report! This seems to be caused by https://github.com/electron/electron/issues/17972

It seems there is a workaround I could apply, but not sure since I'm building on macOS... I might have time to give it a try next week (pull requests also welcome), or even better if they would fix it in the next Electron release...

kiwnix commented 5 years ago

I agree, the user can "workarround" it enabling the userns clone for non-root users via sysctl ( sudo sysctl kernel.unprivileged_userns_clone=1 )

I tried some of the workarrounds on the electron bugreport and i was not able to fix the packaging (first time using electron and electron-builder so not surprising :smile: ), i wish it is fixed in the next electron release too.

mb21 commented 4 years ago

I just released PanWriter 0.6.5, which uses Electron 9... so this is most probably fixed now. Let me know if not!

different55 commented 3 years ago

Trying to run PanWriter 0.7.0 and getting bit by the same bug:

[186912:1216/235608.063896:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_PanWrigmG7YC/chrome-sandbox is owned by root and has mode 4755.

mb21 commented 3 years ago

@different55 what Linux distro/version are you on? Can you try some of the workaround suggested in this electron issue? e.g. executing the AppImage with the --no-sandbox argument?

different55 commented 3 years ago

My bad, yeah. I'm on Debian Sid. Haven't tried --no-sandbox yet, but sudo sysctl kernel.unprivileged_userns_clone=1 did work.

mb21 commented 3 years ago

Great! I didn't really find something I could implement in the code or build/release script... but let me know if you find anything...

different55 commented 3 years ago

--no-sandbox does prevent it from crashing, for some reason it also prevents it from starting properly. It just hangs with no window being created. I'm not seeing any errors out on the terminal except for the "failed to update" ones that I saw even with kernel.unprivileged_userns_clone