search

mb21 / panwriter

Markdown editor with pandoc integration and paginated preview.
https://PanWriter.com
GNU General Public License v3.0
1.06k stars 52 forks source link

Windows installer file type association problematic #31

Open linquize opened 4 years ago

linquize commented 4 years ago

Windows installer: User cannot opt-out file type association. File type association in Windows registry is problematic. After installing panwriter from installer, Explorer -> Right Click -> New -> Text Document is removed because some registry values are wrong.

I want to opt-out file type association.

linquize commented 4 years ago

See https://github.com/electron-userland/electron-builder/issues/2713

mb21 commented 4 years ago

Thanks for the report. But seems there is little we can do until this is fixed in Electron..?

linquize commented 4 years ago

One thing you could do: release a windows portable exe as well as nsis? "win": { "target": [ "portable", "nsis" ] }

mb21 commented 4 years ago

Did you verify that that would fix it?

I'm not a Windows-user... but sounds also like something that should somehow be configurable in the registry or somewhere?

linquize commented 4 years ago

This is not to "fix", but to produce one more output: portable executable. The problematic nsis setup is also produced. Please release both. Since 2 outputs are produced, user can choose to download portable version.

mb21 commented 4 years ago

Yes, but have you verified that the portable version doesn't have this problem? I don't understand why it would be different...?

linquize commented 4 years ago

NSIS setup writes file assoxiations to Windows registry, because you put fileAssociations in package.json. electron-builder will generate write registry code in NSIS script.

Portable exe extracts files to a temporary directory before every run. It does not write to Windows registry. Therefore, portable exe does not have such problem

mb21 commented 4 years ago

I'll take a look for the next release... meanwhile, you can also build it yourself...