fix electron:dev task on windows

mb21 / panwriter

Markdown editor with pandoc integration and paginated preview.

https://PanWriter.com

GNU General Public License v3.0

1.04k stars 51 forks source link

fix electron:dev task on windows #65

Open jan-zajic opened 3 years ago

jan-zajic commented 3 years ago

Fix electron:dev npm task to run also on Windows OS.

mb21 commented 3 years ago

Thanks, I quickly tried this on macOS and got:

yarn run v1.22.10
$ concurrently " set BROWSER=none && yarn start" "wait-on http://localhost:3000 && yarn run electron:tsc -w" "wait-on http://localhost:3000 && yarn run electron:tsc -p electron && set ELECTRON_IS_DEV=1 && electron .
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
error Command failed with exit code 2.

jan-zajic commented 3 years ago

Thank you, sorry for little mistake.. '"' lost somehow during merging/rebasing.. Can you please try it again?

mb21 commented 3 years ago

While it runs now, the env variables aren't set. I don't think there's a syntax that works on both unix and windows... so probably best to add a new command electron:dev:windows or something?