search

mbabaliiryn / bootstrap

1 stars 0 forks source link

Home Page for the newsweek.com built with HTML, CSS and bootstrap #2

Closed mbabaliiryn closed 4 years ago

mbabaliiryn commented 4 years ago

A home page for the newsweek.com built with HTML, CSS and bootstrap.

euqueme commented 4 years ago

Hello @mbabaliiryn :wave:

I have to invalidate your project as it has to have a descriptive PR :v:

Do this change and submit back for a code review

euqueme commented 4 years ago

Hello @mbabaliiryn :wave:

Kindly edit the PR and provide a description as I can't start reviewing without it :point_down:

image

Do the change and submit back for a code review

mbabaliiryn commented 4 years ago

Hello TSE, I accidentally submitted to a wrong project but I was supposed to request code review for bootstrap project.

Can that be corrected?

Regards,

NANYONJO IRENE, 0758323723, mbabaliiryn@gmail.com, Kisaasi - Kampala.

On Wed, 12 Feb 2020 at 08:23, Maria Eugenia Quemé Peña < notifications@github.com> wrote:

Hello @mbabaliiryn https://github.com/mbabaliiryn 👋

Kindly edit the PR and provide a description as I can't start reviewing without it 👇

[image: image] https://user-images.githubusercontent.com/52209067/74305387-63b29c80-4d25-11ea-823e-aec401bebeae.png

Do the change and submit back for a code review

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mbabaliiryn/bootstrap/pull/2?email_source=notifications&email_token=AKXFACTBNRHHC4VSMQH63BLRCOBVPA5CNFSM4KTC4H22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPO6NY#issuecomment-585035575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXFACW22S3BWXVJG5UVXL3RCOBVPANCNFSM4KTC4H2Q .

addod19 commented 4 years ago

Hi @mbabaliiryn, can you Kindly enable stickler for your repo? I cannot start reviewing without it. To enable stickler visit https://stickler-ci.com/

addod19 commented 4 years ago

Pull Request under Review by Daniel Larbi Addo (TSE)

mbabaliiryn commented 4 years ago

Hey Raymond,

Thanks so much for reviewing my code in time. I have done all the required changes and I have submitted back my code for approval.

Regards,

NANYONJO IRENE, 0758323723, mbabaliiryn@gmail.com, Kisaasi - Kampala.

On Tue, 18 Feb 2020 at 13:13, Raymond Oluoch notifications@github.com wrote:

@rOluochKe requested changes on this pull request.

Hello Team! Good job so far 👏 However, there are a few changes you need to work before your project could be approved.

-

Validate your html code with this online tool https://validator.w3.org/#validate_by_upload [image: validator] https://user-images.githubusercontent.com/8114528/74725805-752d0480-524f-11ea-95fa-f7d7eb69183e.PNG

Configure your project with stickler properly, check out this guide https://github.com/microverseinc/linters-config/tree/master/css

Make good use of margin and padding to give your content some space, where required. Boostrap has allows you to do this easily check their documnetation https://getbootstrap.com/docs/4.0/getting-started/introduction/

Use your fonts properly, follow guide from reference website https://www.newsweek.com/

Make these changes and resubmit your project for another coding review.

For assistance: Contact me on @rOluochKe https://github.com/rOluochKe

Happy coding!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mbabaliiryn/bootstrap/pull/2?email_source=notifications&email_token=AKXFACVZFJDX46JSFYKBC2DRDOYDRA5CNFSM4KTC4H22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV4HFQQ#pullrequestreview-360215234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXFACSKXWPBLXP764B6EJ3RDOYDRANCNFSM4KTC4H2Q .