Closed mbaeuerle closed 2 years ago
Hey, @mbaeuerle . I've made just a comment in the PR with a suggestion. Other than that, it looks good to me.
Regards
@cleydyr thanks for reviewing. Maybe I'm a bit blind today, but unfortunately I could not find your comment. Maybe it's still pending?
Didn't mention you. 🤦 I thought Github would notify you anyway. Fixed.
@cleydyr Still cannot see any comment 😮 if you started a review (instead of writing a single comment) you need to submit it first before I can see it. Otherwise the comments are still in pending state. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#submitting-your-review
This PR will introduce a new way of how crop rects are selected. Prevously:
ctrl
+ clickWith this PR:
Shift
+ click adds a rect to the selection (or removes it if it was already part of it)I think that is a more natural way for selecting objects, less cumbersome and is also more familiar from other tools like Powerpoint, Keynote, etc.