mbakeranalecta / sam

Semantic Authoring Markdown
Other
79 stars 8 forks source link

Adding Embed object for model consistency #176

Closed mbakeranalecta closed 6 years ago

mbakeranalecta commented 6 years ago

An embedded block is represented by its own object, and EmbedBlock. But an inline embed is represented by a Code object and distinguished by the presence of an embed attribute. For consistency it should be its own object.

mbakeranalecta commented 6 years ago

This is not so easy because blocks and phrases are parsed differently and at the time that the Code object is created we have not yet seen the annotation that will tell us if this is code or an embed. Would need to change the way the string is parsed in order to know which object to create.

mbakeranalecta commented 6 years ago

Addressed in 4e117a00cb1febf745a3f2c59cdc92a5bcd11abb. Documented in 011182ce4a8f7395f20c52abe0912a677b52dd76.