mbakker7 / timml

An analytic element model for steady multi-layer flow
MIT License
38 stars 21 forks source link

Add BuildingPit element and example notebook #21

Closed ghost closed 5 years ago

ghost commented 5 years ago

Add BuildingPit element, including new equation Example notebook added for BuildingPit Multiprocessing implementation ml.solve_mp() added to model.py. Speedup about equal to number of physical cores.

ghost commented 5 years ago

Some checks aren't passing on the commits where i updated my fork from original source via PR... I probably didn't do that correctly. Any help on how to do this correctly would be appreciated!

jentjr commented 5 years ago

One of the issues is with the .travis.yml build configuration. A new environment needs to be created and activated for each version of python by adding the following:

`

The last build before your pull request was failing because of this.

The other issue I believe is with the import at the beginning of the BuildingPit notebook. Try deleting
import sys sys.path.insert(1, "..")

ghost commented 5 years ago

Thanks for the suggestions! It seems to work now.

mbakker7 commented 5 years ago

Pretty cool new element. Gotta work with it some to get familiar with it.