search

mbakker7 / ttim

MIT License
33 stars 23 forks source link

Move to Github Actions #36

Closed dbrakenhoff closed 2 years ago

dbrakenhoff commented 2 years ago

@mbakker7 there are some undefined methods/variables in circinhom.py which is causing the flake8 check to fail. Should these be fixed? Or should I ignore the file for now?

mbakker7 commented 2 years ago

circinhom is not operational yet. you can ignore the file for now (but obviously keep it)

On Sat, Jan 15, 2022 at 5:53 PM Davíd Brakenhoff @.***> wrote:

@mbakker7 https://github.com/mbakker7 there are some undefined methods/variables in circinhom.py which is causing the flake8 check to fail. Should these be fixed? Or should I ignore the file for now?

— Reply to this email directly, view it on GitHub https://github.com/mbakker7/ttim/pull/36#issuecomment-1013715352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKM3SFKEJDURO3QIJSP663UWGRAHANCNFSM5MBFL3UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

mbakker7 commented 2 years ago

Ready to merge?

dbrakenhoff commented 2 years ago

Yes!