search

mbakker7 / ttim

MIT License
34 stars 23 forks source link

Formatting black+isort #44

Closed dbrakenhoff closed 1 year ago

mbakker7 commented 1 year ago

Looks like from tqdm.auto import trange doesn't run. Should tqdm be listed as a dependency?

Also, maybe delete Python 3.7 and add 3.10 and 3.11?

All dependencies are now listed in requirements.ci.txt, and we don't have a pyproject.toml file yet. Maybe that can be added as well? Or in a separate PR?

dbrakenhoff commented 1 year ago

Ah, I accidentally left the tqdm stuff in there.

We could add it as a dependency and use it as a progressbar for anything that takes a while? But that should be a separate PR so removing it from here.

I'll submit the pyproject.toml and modify the CI in another PR.

mbakker7 commented 1 year ago

Looks good. Ready to merge?

mbakker7 commented 1 year ago

Ah, I accidentally left the tqdm stuff in there.

We could add it as a dependency and use it as a progressbar for anything that takes a while? But that should be a separate PR so removing it from here.

I'll submit the pyproject.toml and modify the CI in another PR.

Sounds good. Looking forward to another PR.