mbakker7 / ttim

MIT License
33 stars 23 forks source link

Pumping Test benchmark notebooks #58

Closed vcantarella closed 7 months ago

vcantarella commented 9 months ago

Hi Mark,

Thanks for the opportunity to contribute to the project. This contains all the notebooks with the pumping test benchmarks done in 2021. Once added to the repository, we need to fix the hyperlinks inside the Readme.md file and inside each notebook because they are currently referring to my local repository files.

Let me know if there is something missing, or that I can help with.

Cheers,

Vitor

mbakker7 commented 9 months ago

Thanks for the PR, @vcantarella We would like to include this in ttim, but cannot include it with errors in master. I just created a new branch pumpingtests from the dev branch. As you can see, the pumpingtests branch has no subdirectory pumpingtest anymore in the root. Please create a new pumpingtest directory and put your notebooks (and, I presume, a data directory) in that new directory. Please don't change any other files. Then submit a new PR so that we can accept your notebooks in this new directory. After that, we can move it in the new ReadTheDocs structure.

vcantarella commented 9 months ago

Thanks Mark, looks like when I merged your branch I added some old files to your docs. Is everything working now? Or should I make a new fork and pull again?

mbakker7 commented 9 months ago

I think all is fixed now. I started to update Notebook 1 (Oude Korendijk). All other notebooks need to be changed in a similar fashion. Is a bit of work. Feel free to chip in.

vcantarella commented 9 months ago

Sure, got it!