nsapi-sdk support (r481) produces make error

[GoogleCodeExporter]

What steps will reproduce the problem?
1. checkout r481 from svn
2. cd gecko-mediaplayer
3. ./configure
4. make

What is the expected output? What do you see instead?

The latest revision (r481) seems to clash with xulrunner (at least with the 
most recent version for ubuntu maverick) and produces make errors (added output 
below). Former svn checkouts have been building just fine untill now. Please 
feel free to ask for more information if needed.

A big 'thank you' for your efforts on gecko-mediaplayer, gnome-mplayer and 
other projects.

- - make output - -

make  all-recursive
make[1]: Entering directory `/home/glitsj16/.devzone/gecko-mediaplayer'
Making all in src
make[2]: Entering directory `/home/glitsj16/.devzone/gecko-mediaplayer/src'
make[3]: Entering directory `/home/glitsj16/.devzone/gecko-mediaplayer/src'
  CXX    plugin_types_std.o
  CXX    memmem_compat.o
  CXX    plugin.o
  CXX    plugin_list.o
  CXX    plugin_setup.o
  CXX    plugin_dbus.o
  CXX    np_entry.o
  CXX    npn_gate.o
  CXX    npp_gate.o
  CXX    plugin_types_qt.o
  CXX    plugin_types_wmp.o
  CXX    plugin_types_rm.o
  CXX    plugin_types_dvx.o
In file included from np_entry.cpp:44:
npupp.h:703: error: declaration of C function ‘const char* 
NP_GetMIMEDescription()’ conflicts with
/usr/include/xulrunner-1.9.2.24/npfunctions.h:274: error: previous declaration 
‘char* NP_GetMIMEDescription()’ here
np_entry.cpp:83: error: new declaration ‘const char* 
NPP_GetMIMEDescription()’
/usr/include/xulrunner-1.9.2.24/npapi.h:622: error: ambiguates old declaration 
‘char* NPP_GetMIMEDescription()’
make[3]: *** [np_entry.o] Error 1
make[3]: *** Waiting for unfinished jobs....
npp_gate.cpp: In function ‘const char* NPP_GetMIMEDescription()’:
npp_gate.cpp:47: error: new declaration ‘const char* 
NPP_GetMIMEDescription()’
/usr/include/xulrunner-1.9.2.24/npapi.h:622: error: ambiguates old declaration 
‘char* NPP_GetMIMEDescription()’
make[3]: *** [npp_gate.o] Error 1
make[3]: Leaving directory `/home/glitsj16/.devzone/gecko-mediaplayer/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/glitsj16/.devzone/gecko-mediaplayer/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/glitsj16/.devzone/gecko-mediaplayer'
make: *** [all] Error 2

What version of the product are you using? On what operating system?

r481 on ubuntu 10.10 (maverick)

Please provide any additional information below.

xulrunner-1.9.2 1.9.2.24+build2+nobinonly-0ubuntu0.10.10.1
xulrunner-1.9.2-dev 1.9.2.24+build2+nobinonly-0ubuntu0.10.10.1

Original issue reported on code.google.com by glits...@gmail.com on 1 Dec 2011 at 9:38

[GoogleCodeExporter]

Looks like the latest patch from issue 158 is conflicting with your old ubuntu. 
For now I would recommend editing npupp.h and removing the 'const' from line 703

I checked with the xulrunner-devel package in Fedora and those declarations are 
not present. So maybe this is a change in the API

Can you post the output of this command

pkg-config --modversion libxul

if that doesn't work try this one

pkg-config --modversion xulrunner

Also how are you running configure?

Original comment by kdeko...@gmail.com on 1 Dec 2011 at 9:48

[GoogleCodeExporter]

I do see this problem on my machine running RHEL 6.2, so I think I can fix it.

Original comment by kdeko...@gmail.com on 1 Dec 2011 at 9:51

[GoogleCodeExporter]

Can you test SVN r483 and see if that fixes it for you, it did for me.

Original comment by kdeko...@gmail.com on 1 Dec 2011 at 10:03

[GoogleCodeExporter]

Just tested SVN r483 and I can confirm this indeed fixes things beautifully. 
Many thanks for taking the time and the effort to support older xulrunners :)

Original comment by glits...@gmail.com on 2 Dec 2011 at 12:49

[GoogleCodeExporter]

Original comment by kdeko...@gmail.com on 2 Dec 2011 at 9:00

• Changed state: Fixed