search

mbalabash / estimo

Evaluates how long a browser will execute your javascript code
MIT License
170 stars 12 forks source link

Allow to use tool on Node 6 #14

Closed ai closed 5 years ago

ai commented 5 years ago

Because of a few political problems I need to support Node.js 6 in Autoprefixer for few months.

Estimo uses Node.js 8+ code in chromeDetection.js and it breaks CI.

I suggest adding ESTIMO_DISABLE environment variable to not even loading chromeDetection.js in findChrome.js. It could be useful in many cases.

I didn’t move PUPPETEER_SKIP_CHROMIUM_DOWNLOAD, because with PUPPETEER_SKIP_CHROMIUM_DOWNLOAD Estimo looks for local Chrome now (and I do not want breaking changes).

ai commented 5 years ago

@mbalabash oops. Thanks for the review. I fixed changes.

mbalabash commented 5 years ago

Released in estimo@1.1.5