Use PUPPETEER_EXECUTABLE_PATH variable if available

mbalabash / estimo

Evaluates how long a browser will execute your javascript code

MIT License

170 stars 12 forks source link

Use PUPPETEER_EXECUTABLE_PATH variable if available #19

Closed schibrikov closed 5 years ago

schibrikov commented 5 years ago

It allows indirect users (such as ones using size-limit) to specify chrome executable through ENV variable compatible with Puppeteer.

Added this way it will have higher priority than executable found on postinstall, but smaller priority than the one specified in function parameter. I think it's reasonable enough.

schibrikov commented 5 years ago

Original issue https://github.com/ai/size-limit/pull/145 @ai

ai commented 5 years ago

@mbalabash Seems like we forgot one variable during our copy-pasting find-chrome

mbalabash commented 5 years ago

Released in estimo@2.0.1.