search

mbalabash / estimo

Evaluates how long a browser will execute your javascript code
MIT License
170 stars 12 forks source link

Add --no-sandbox for Puppeter #8

Closed ai closed 5 years ago

ai commented 5 years ago

It will make Puppeter work on CI

https://github.com/ai/size-limit/issues/113

igorkamyshev commented 5 years ago

It not for any CI, I guess. But definitely for GitHub Actions.

aslushnikov commented 5 years ago

For many CI's there's a way to enable sandboxing appropriately: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#setting-up-chrome-linux-sandbox

We didn't look into Github Actions yet though

igorkamyshev commented 5 years ago

Yep, sure. I suggest add this option to your package. I tried to run a size-limit in GitHub Actions and need this parameter.

igorkamyshev commented 5 years ago

@mbalabash hey, friendly ping =)

I want use Size Limit in GitHub Actions and I really need this option. If you agree with this proposal, I can make a PR with this changes.

mbalabash commented 5 years ago

Hello @igorkamyshev I'm was in vacation, sorry for slow response 🙃 Tomorrow i will add this option and test it asap.

mbalabash commented 5 years ago

@igorkamyshev I'm added this option.

It not for any CI, I guess. But definitely for GitHub Actions.

You are right. Travis CI still fails.

Tracium throws Fatal trace logic error - child cannot end after parent only in docker environment. Bad part is, this behavior unstable for same docker container and tests.

@aslushnikov Do you have any ideas?

aslushnikov commented 5 years ago

@mbalabash do you have a trace that throws this error? Can you please share it?

mbalabash commented 5 years ago

@aslushnikov Sure. https://pastebin.com/raw/KzLpMMqK

mbalabash commented 5 years ago

@igorkamyshev released in v1.0.0