mbaraa / dsc_logo_generator

The most optimized and working GDSC logo generator!
https://gdsclogo.mbaraa.xyz
GNU General Public License v3.0
28 stars 5 forks source link

Issues with file output when the name contains `.` and a `.svg` render is requested #6

Open anishshobithps opened 1 year ago

anishshobithps commented 1 year ago

As the title suggests, if the college/university name contains a ., such as St. Joseph Engineering College, the .png does not download due to the St.

image

It works perfectly when I remove it

image

Also, it would be nice if there was a way to download render images in .svg format rather than .png format, or perhaps an option?

mbaraa commented 1 year ago

thanks for your notice, if you can make a pull request with the suggested changes that would be great.

if not, then I'll fix them as soon as I can!

mbaraa commented 1 year ago

Fixed the file name issue so far, for the SVG output, should it be any transparent SVG or like the gdsc logo template's svg?

anishshobithps commented 1 year ago

Fixed the file name issue so far, for the SVG output, should it be any transparent SVG or like the gdsc logo template's svg?

Thanks for the fixing the name part, for the svg output, its better if its transparent because I have seen multiple use it as website logo

mbaraa commented 1 year ago

there is a transparent background with the regular PNG download ezgif com-gif-maker

anishshobithps commented 1 year ago

there is a transparent background with regular PNG download

Yes, maybe I am a man with who likes clarity 💀, if its not possible no worries :) . As SVG is a vector it looks cleaner and does not pixelate hence the request

mbaraa commented 1 year ago

ok I'll see what I can do with that 👍🏼

mbaraa commented 1 year ago

also if you know Go or SvelteKit, feel free to open a pull request, I'm kind of busy these days!

anishshobithps commented 1 year ago

There is no hurry :), I don't have any knowledge in Go and I have only tried SvelteKit once, I am practically new to web development all together, all the period (.) issue was more important thanks for the fix 👍🏼

mbaraa commented 1 year ago

Okay then, wish you all the luck, PS I noticed that you're building a GDSC website, you could use our template if you like to, or even help us to make it better!