mbarbetti / pidgan

:package: GAN-based models to flash-simulate the LHCb PID detectors
GNU General Public License v3.0
3 stars 1 forks source link

Need for modernizing the training scripts available in the repository #11

Open mbarbetti opened 5 days ago

mbarbetti commented 5 days ago

The Python scripts contained in pidgan/scripts are intended for preparing the set of models required to parameterize the high-level response (i.e., flash-simulation) of the LHCb PID system. Even if perfectly functional, they are quite rude and may benefit from some code enhancement.

For example, they do not implement any proper logging system, preferring to trace the program execution by using the print() function. A generic user may deeply benefit from the use of a modern logging package like Loguru or one of the others described in this highlight.io post.

Or again, each Python script requires a minimal CLI that is currently implemented through the Python built-in argparse module. The same CLI can be easily implemented by using Typer with great benefits as highlighted by Marie Stephen Leo in this LinkedIn post.

1718806182954