mbarbin / vcs

A Versatile OCaml Library for Git Operations
https://mbarbin.github.io/vcs/
GNU Lesser General Public License v3.0
7 stars 0 forks source link

Vendoring #2

Closed mbarbin closed 5 months ago

mbarbin commented 6 months ago

Switch some dependencies from opam to vendor/.

The goal is to help progress towards publishing vcs, #1.

mbarbin commented 6 months ago

I just learned today about another approach to a public lib depending on a private lib here: https://github.com/ocaml/dune/issues/10230

I'd like to hold off merging this PR until I can try out whether this other approach makes sense here.

mbarbin commented 5 months ago

From what I could gather it seems with the other approach, you may use a private lib in the scope of a single package, whereas here we rather re-use some private libs across multiple vcs packages, thus the scheme that's in the PR makes sense.