search

mbari-org / SeafloorMappingDB

Make MBARI seafloor mapping datasets more accessible and useful
GNU General Public License v3.0
3 stars 6 forks source link

Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… #264

Closed ksalamy closed 3 weeks ago

ksalamy commented 5 months ago

Request the removal of Geoman (Leaflet Plugin For Creating And Editing Geometry Layers) from Home Map.

Geoman is not needed. Removing it from the SMDB UI code base.

ksalamy commented 4 weeks ago

Please review and merge this edit. -K

ksalamy commented 4 weeks ago

Also, adding new commit for #261 (Content of detail views hidden behind page header #261). Please review and merge into main.

ksalamy commented 3 weeks ago

Mike,

The pull request for Geoman removal was sent 4 months ago. No, major changes to the css were not required that update.

However, I recently made changes to the view of various pages to resolve several reported issues, some including the view of your Crispy Forms, so that css works with all. This involved updating the filter.css.

These updates were detailed as another change (by issue #261) within the original pull request. The css changes I have made are needed so that specific page-based requests do not affect the entire UI. Please review and merge these pull requests.

Karen

Karen A. Salamy Associate SW Engineer, MBARI P 831.775.1820 , F 831.775.1620

Monterey Bay Aquarium Research Institute (MBARI) 7700 Sandholdt Road, Moss Landing CA 95039 [ http://www.mbari.org/ | www.mbari.org ] Advancing marine science and engineering to understand our changing ocean.

"If we knew what it was we were doing, it would not be called research, would it?" - Albert Einstein (1879-1955)

P Please consider the environment before printing this e-mail.

From: "Mike McCann" @.> To: "mbari-org/SeafloorMappingDB" @.> Cc: "Karen Salamy" @.>, "Assign" @.> Sent: Monday, October 28, 2024 10:58:51 AM Subject: Re: [mbari-org/SeafloorMappingDB] Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… (PR #264)

[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]

@MBARIMike commented on this pull request.

I'm curious about the new CSS IDs added to filters.css. Are they necessary for the removal of Geoman?

— Reply to this email directly, [ https://github.com/mbari-org/SeafloorMappingDB/pull/264#pullrequestreview-2399815354 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ADB52CJ22CYMME6EIAQYGELZ5Z3NXAVCNFSM6AAAAABJSREBMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJZHAYTKMZVGQ | unsubscribe ] . You are receiving this because you were assigned. Message ID: @.***>

MBARIMike commented 3 weeks ago

Okay. I will merge this PR and pull to production, but there are still issues with detail page rendering.

ksalamy commented 3 weeks ago

Hi Mike,

I know there are still some issues with pages rendering. You stated you wanted me to do small incremental changes instead of larger updates all at once.

I will have more pull requests this week.

Karen

Karen A. Salamy Associate SW Engineer, MBARI P 831.775.1820 , F 831.775.1620

Monterey Bay Aquarium Research Institute (MBARI) 7700 Sandholdt Road, Moss Landing CA 95039 [ http://www.mbari.org/ | www.mbari.org ] Advancing marine science and engineering to understand our changing ocean.

"If we knew what it was we were doing, it would not be called research, would it?" - Albert Einstein (1879-1955)

P Please consider the environment before printing this e-mail.

From: "Mike McCann" @.> To: "mbari-org" @.> Cc: "Karen Salamy" @.>, "Assign" @.> Sent: Monday, October 28, 2024 3:33:05 PM Subject: Re: [mbari-org/SeafloorMappingDB] Issue #263 - Request the removal of Geoman (Leaflet Plugin For Creati… (PR #264)

[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]

Okay. I will merge this PR and pull to production, but there are still issues with detail page rendering.

— Reply to this email directly, [ https://github.com/mbari-org/SeafloorMappingDB/pull/264#issuecomment-2442798181 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ADB52COOZZXPGRNCOU6ZHTTZ523SDAVCNFSM6AAAAABJSREBMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSG44TQMJYGE | unsubscribe ] . You are receiving this because you were assigned. Message ID: @.***>

MBARIMike commented 2 weeks ago

This PR has been pulled to production.