mbari-org / Sharktopoda

Mac Video Player for creating, editing, and viewing localizations.
Apache License 2.0
2 stars 1 forks source link

Updating a selected localization leaves the label in the old position unless the localization is reselected #26

Closed hohonuuli closed 1 year ago

hohonuuli commented 1 year ago

Steps to reproduce:

  1. Open a video (do not play)
  2. Send an add localization command
  3. Send a seek to localizations elapse time command
  4. Send a select localization command so that it's selected (and to make it's label visible.)
  5. Send an update localization command to move the localization

This leaves the label visible in the old position.

Before update

Issue19

After update

Notice the Brian was here message is still visible in the old position.

Issue19b

hohonuuli commented 1 year ago

Here's my communications log from the steps to create this issue:

2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RemoteControl$Builder - Building. Listening on port 5555. Sending commands to localhost:8800
2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.player.PlayerIO - anicca.lan:5555 - Started server's receiver thread: Thread-1
2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "port": 5555,
  "host": "anicca.lan",
  "command": "connect"
}
2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"connect","status":"ok"}
2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "url": "http://varsdemo.mbari.org/media/M3/mezzanine/Ventana/2017/03/4003/V4003_20170301T185553.933Z_t2s4_hd_tc01495915_h264.mp4",
  "command": "open",
  "uuid": "16680b0c-e1f8-4930-8d95-d353381df989"
}
2022-12-20 10:44:31 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"open","status":"ok"}
2022-12-20 10:44:31 [Thread-1] DEBUG org.mbari.vcr4j.remote.player.PlayerIO - anicca.lan:5555 - Received command <<< {"command":"open done","status":"ok","uuid":"16680b0c-e1f8-4930-8d95-d353381df989"}
2022-12-20 10:44:31 [Thread-1] DEBUG org.mbari.vcr4j.remote.player.PlayerIO - anicca.lan:5555 - Responding >>> {
  "response": "open done",
  "status": "ok"
}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "localizations": [
    {
      "uuid": "f61167be-3444-4936-a127-048a99b28c86",
      "concept": "Brian was here",
      "elapsedTimeMillis": 10000,
      "durationMillis": 0,
      "x": 100,
      "y": 200,
      "width": 300,
      "height": 400,
      "color": "#FF3434"
    }
  ],
  "command": "add localizations",
  "uuid": "16680b0c-e1f8-4930-8d95-d353381df989"
}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"add localizations","status":"ok"}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "elapsedTimeMillis": 10000,
  "command": "seek elapsed time",
  "uuid": "16680b0c-e1f8-4930-8d95-d353381df989"
}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"seek elapsed time","status":"ok"}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "localizations": [
    "f61167be-3444-4936-a127-048a99b28c86"
  ],
  "command": "select localizations",
  "uuid": "16680b0c-e1f8-4930-8d95-d353381df989"
}
2022-12-20 10:44:33 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"select localizations","status":"ok"}
2022-12-20 10:44:38 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Sending command >>> {
  "localizations": [
    {
      "uuid": "f61167be-3444-4936-a127-048a99b28c86",
      "concept": "Brian is now over here",
      "elapsedTimeMillis": 10000,
      "durationMillis": 0,
      "x": 500,
      "y": 500,
      "width": 300,
      "height": 400,
      "color": "#FF3434"
    }
  ],
  "command": "update localizations",
  "uuid": "16680b0c-e1f8-4930-8d95-d353381df989"
}
2022-12-20 10:44:38 [org.mbari.vcr4j.examples.remote.Issue19.main()] DEBUG org.mbari.vcr4j.remote.control.RVideoIO - 16680b0c-e1f8-4930-8d95-d353381df989@localhost:8800 - Received response <<< {"response":"update localizations","status":"ok"}
hohonuuli commented 1 year ago

Just pulled latest changes. This issue is resolved.