mbari-org / annosaurus

Service for storing and retrieving video/image annotations from VARS
https://docs.mbari.org/annosaurus/
Apache License 2.0
1 stars 1 forks source link

Count/find imaged moments by images and association link name #13

Closed kevinsbarnard closed 2 years ago

kevinsbarnard commented 2 years ago

Duplicate of https://github.com/kevinsbarnard/annosaurus/pull/1.

Added endpoints:

  1. /v1/imagedmoments/count/all returns a count of all imaged moments
  2. /v1/imagedmoments/count/images returns a count of imaged moments with at least one valid (non-null URL) image reference
  3. /v1/imagedmoments/find/images returns the imaged moments " " " "
  4. /v1/imagedmoments/count/linkname/:linkname returns a count of imaged moments with at least one association with the given link name
  5. /v1/imagedmoments/find/linkname/:linkname returns the imaged moments " " " "

Unit tests to cover each new endpoint are included.

hohonuuli commented 2 years ago

Running integration tests before merging into master.

hohonuuli commented 2 years ago

Integration tests are good. Nice work! Just a heads up that, as a I mentioned, the JPA fetch is sluggish so if it turns out to be a show stopper for your use case, I can get you going on a SQL alternative. The changes are in release at https://github.com/mbari-media-management/annosaurus/releases/tag/0.13.0 . New arm/amd images pushed to docker hub.

kevinsbarnard commented 2 years ago

Thanks Brian! I see what you mean- I'll see what I can do next week.