mbari-org / cthulhu

Cross-platform video player that supports annotation localizations (i.e. bounding boxes)
https://mbari-media-management.github.io/cthulhu/
Other
4 stars 2 forks source link

Fix 2 multi box single frame #7

Closed carueda closed 3 years ago

carueda commented 3 years ago

Hey @hohonuuli I think I have fixed this, even for small time window (like the 100ms we've been using lately).

Here's a video I just uploaded demonstrating this: https://youtu.be/YSjQQAk3qlw

(I used thee button for pause/play because of some associated logging I was also inspecting -- otherwise, just usual space bar...)

The key aspect for the solution here is to do one more call to the handler in the timer when the video has just been paused, in this case with whatever last time is reported from the video player.

Please test it on your side when convenient.

hohonuuli commented 3 years ago

@carueda Thanks Carlos! I probably won't get to this until Monday but I'll review it then.

carueda commented 3 years ago

I just repeated the exercise: https://youtu.be/325z9oMP30k

In particular, this shows the expected yellow color for the boxes just being drawn/finalized. In the previous video taken yesterday those boxes were always white for some reason (... probably because of a slower vpn connection(?)).

carueda commented 3 years ago

Thanks for reviewing @hohonuuli . No problem commenting out those conditioned trace logging statements, but note that they should be really pretty fast:

However, I agree and will comment those given the time sensitive section in which they are. They are great for debugging, so rather easy to uncomment when needed.

I'll also look into the your other comment.

carueda commented 3 years ago

Changes done.

hohonuuli commented 3 years ago

Rebased into master and deleted this branch.