Open sqshemet opened 8 months ago
jimjeffers
commented
7 months ago @ksalamy the dash 5 already does this. It looks like the API has drifted from the client library in dash or a bug in the API has been introduced. I would consult with @carueda to determine if there is an issue on the server or if the dash 5 is not making calling the /git/missionList as expected.
See the block that injects the available missions into the dropdown on the mission modal.
ksalamy
commented
7 months ago Hi @jimjeffers. I believe this issue may be directly related to #305 - https://github.com/mbari-org/dash5/issues/305 which was the deprecation of using GET /info/vehicles on Tethysdash to GET /info. I have a request out to @carueda to clarify all of the endpoint calls that may need adjusting to sync dash5 with changes on the server.
carueda
commented
7 months ago /info/vehicles hasn't been removed, you can confirm by just visiting https://okeanids.mbari.org/TethysDash/api/info/vehicles
/git/missionList: oh, seems like a regression here (a 500 is being returned). Will look into that. Dash4 doesn't use it so I was not aware of the regression until now. (dash4 uses one other endpoint, which provides listing per subdirectory -- the /missionList was added per request from you guys a long while ago.)
carueda
commented
7 months ago Just fixed the regression, which only occurred when no gitRef parameter is given in the GET /git/missionList request. You can visit https://okeanids.mbari.org/TethysDash/api/git/missionList to see the expected response.
ksalamy
commented
7 months ago @sqshemet Could you check to see if the regression fix by Carlos resolves this issue for you? If not, let me know. Thanks!
Is your feature request related to a problem? Please describe. We have a lot of missions! Some of them we only run occasionally or seasonally, and we're adding new missions often. I don't see a way to run missions other than those that are Recent or Frequent in the missions display. Trying to use search for missions I know exist doesn't work either. We need a way to see and run all existing missions.
Describe the solution you'd like I really like how the command modal gives a list of possible options and their descriptions. Most of our missions have descriptions (and we're trying to get better about that), it would be great to see a similar dialogue. Maybe the first screen is the broader mission category (Science/Engineering/Maintenance/etc) and then the next a list of the missions in that category?
Describe alternatives you've considered The dash4 picker, with no mission descriptions, is functional. Reimplementing that would be fine, but I think we can do better :)
Additional context Add any other context or screenshots about the feature request here.