mbari-org / vars-annotation

Video Annotation Application for MBARI's Media Management (M3) software stack
https://docs.mbari.org/vars-annotation/
Apache License 2.0
16 stars 6 forks source link

Localizations on concurrent media will be displayed at wrong time if source media has different time. #151

Closed hohonuuli closed 1 year ago

hohonuuli commented 1 year ago

In VARS if we are displaying concurrent annotations and the concurrent video has a different start time, the localizations will be displayed offset from their correct elapsed time on the media being annotated, Found this using the following videos:

I add annotations to the prores , then opened the MP4, seek goes to the correct frame, but the localization is not displayed there.

hohonuuli commented 1 year ago

Here's the current requirements for an annotation to be editable/displayed using VARS and Sharktopoda:

hohonuuli commented 1 year ago

A nice to have is that when a user opens a media, it should popup and warn them that some concurrent localizations can't be edited on the current media.

hohonuuli commented 1 year ago

In order to make this fast I added a CachedMediaService so we don't have to make a rest call every time we need to lookup a different media object than the currently opened one.

hohonuuli commented 1 year ago

I've changed the logic in VARS. If the localization is on a concurrent annotation, it can only be viewed/edited in Sharktopoda if:

  1. The concurrent video has the same start time as the opened video
  2. The concurrent video hast the same dimensions (width, height) as the opened video.