search

mbari-org / vars-annotation

Video Annotation Application for MBARI's Media Management (M3) software stack
https://docs.mbari.org/vars-annotation/
Apache License 2.0
16 stars 6 forks source link

Inconsistent entry of annotations #47

Closed lonnylundsten closed 6 years ago

lonnylundsten commented 6 years ago

Using the VARS anno GUI that was released today, entering annotations is very inconsistent. After typing in the concept name, it takes 1, 2, or 3 presses of the enter button for the annotation to 'stick.' When it takes 2-3+ presses of the enter button, VARS becomes very hard to use.

hohonuuli commented 6 years ago

I think this is what's going on. Caching of concept data is now handled differently. Previously, a process was running in the background that loaded the entire knowledgebase piece-by-piece. This was done mainly in order to fetch the alternate names for a concept. It tends to put a stress on the vars-kb-server microservice. Now, the first time you use a concept, the annotation app makes a call to fetch from the microservice, then caches it. Much more efficient, but makes for slower response times.

The code for making the call is in AnnotationEditorPaneController. This, is in turn, making call into CacheConceptService2.

With the new load path for concept-names, I don't need to call findDetails in the ConceptService. I'll replace this with a call to findConcept instead as a Concept should now contain the alternative names.

hohonuuli commented 6 years ago

New release tagged and built.

hohonuuli commented 6 years ago

Most of the fix is in CachedConceptService3.java